ci: Upload stacker binary #556
Conversation
Uploading a c-i built binary can make it easier for users to test. Signed-off-by: Scott Moser <smoser@brickies.net>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
==========================================
+ Coverage 54.24% 54.30% +0.05%
==========================================
Files 64 64
Lines 7473 7473
==========================================
+ Hits 4054 4058 +4
+ Misses 2728 2724 -4
Partials 691 691 ☔ View full report in Codecov by Sentry. |
|
You can see the 'binary' and 'binary-cov' artifacts https://github.com/project-stacker/stacker/actions/runs/6932027516?pr=556 (scroll down, 'Artifacts') |
|
Stupid question: how long will github keep these artifacts? I assume this is a handled problem, and it has reasonable retention times and auto-purge .... |
| if: ${{ matrix.privilege-level == 'priv' }} | ||
| with: | ||
| # if there is more than 1 go-version, we would need to account for that here. | ||
| name: binary |
There was a problem hiding this comment.
If you want we can call it stacker. but what that creates is a zip file name 'stacker.zip' which contains stacker. I'd prefer 'binaries' or 'binary' as its an archive (potentially multiple things).
So its not like it is a single thing that that you can download it and use it, in which case 'stacker' and 'stacker-cov' would be the right name.
I'll rename it if you want though.
| if: ${{ matrix.privilege-level == 'priv' }} | ||
| with: | ||
| # if there is more than 1 go-version, we would need to account for that here. | ||
| name: binary-cov |
90 days by default [1]:
|
Uploading a c-i built binary can make it easier for users to test.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.